[Skiboot] [PATCH] Run pollers in time_wait() when not booting

Stewart Smith stewart at linux.ibm.com
Wed Oct 31 17:00:09 AEDT 2018


Russell Currey <ruscur at russell.cc> writes:
> On Wed, 2018-10-31 at 15:21 +1100, Andrew Donnellan wrote:
>> + ruscur
>> 
>> On 30/10/18 10:15 pm, Andrew Jeffery wrote:
>> > But it passes snowpatch according to patchwork :thinking_face:
>> 
>> https://openpower.xyz/job/snowpatch/job/snowpatch-skiboot/192//artifact/skiboot/build.log/*view*/
>> 
>> ...
>> 	[CC]  platforms/qemu/qemu.o
>> 	[CC]  platforms/astbmc/vesnin.o
>> 	[CC]  platforms/mambo/mambo.o
>> 	[CC]  platforms/astbmc/romulus.o
>> 	[CC]  platforms/astbmc/p9dsu.o
>> 	[CC]  platforms/mambo/console.o
>> /var/lib/jenkins-slave/workspace/snowpatch/snowpatch-
>> skiboot/skiboot/Makefile.rules:56: 
>> recipe for target 'core/timebase.o' failed
>> 
>> "success"
>> 
>> hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm...............
>> 
>
> Gentlemen, if you observe what snowpatch reports you'll clearly see
> it's boned:
>
> http://patchwork.ozlabs.org/patch/990670/
>
> and by that I mean I added "|| exit 1" to the "docker run" command and
> ran the tests again.
>
> This is clearly docker's fault and not mine.

Yes. I too blame Docker. Especially for all my bugs in firmware. Or misc
other life problems.

Seriously though, thanks for fixing it.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list