[Skiboot] [PATCH] pflash: Add --skip option for reading

Stewart Smith stewart at linux.ibm.com
Wed Oct 31 15:52:31 AEDT 2018


Adriana Kobylak <anoo at linux.ibm.com> writes:
>> Thanks, merged to master as of 
>> b6ebee077d915916989aa3057239a985981edb07.
>> 
>
> Thanks
>
>> Does it make sense to also have a --skip-stb-header option?
>> 
>> I don't like us relying on the stb header just being 4096 bytes, but
>> IIRC everywhere else hardcodes it too... I'm mostly wondering about not
>> building too much knowledge of host firmware into OpenBMC.
>
> I started that way, but seems we'd need additional changes when building
> pflash to find the libstb/container.h, and since this new option is 
> intended
> to be used by users and not built into any code, this generic option is
> probably ok for now.
> If there are more features related to secure boot that we need to add to
> pflash or requests from people we can revisit then.

Yeah, I figured as much - and skipping into a partition is a valid
enough thing to do anyway (dd has it for example).

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list