[Skiboot] [PATCH 1/2] core/flash: NULL pointer dereference fixes
npiggin at gmail.com
Tue Oct 30 15:19:49 AEDT 2018
On Fri, 26 Oct 2018 10:08:30 +1100
Stewart Smith <stewart at linux.ibm.com> wrote:
> Nicholas Piggin <npiggin at gmail.com> writes:
> > These were caught with unmapped memory dereference page faults.
> > Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> > ---
> > core/flash-subpartition.c | 15 +++++++++------
> > core/flash.c | 6 +++++-
> > 2 files changed, 14 insertions(+), 7 deletions(-)
> Thanks, series merged to master as of
> Did we see any real failures with this, as in, should we backport to stable?
No failures in upstream skiboot. I think by luck, *(uint32_t *)0 == 0
The NULL branch catcher writes a function address there, but the first
4 bytes of it are zeroes.
More information about the Skiboot