[Skiboot] [PATCH] pflash: Add --skip option for reading

Stewart Smith stewart at linux.ibm.com
Fri Oct 26 10:17:20 AEDT 2018


Adriana Kobylak <anoo at linux.ibm.com> writes:
> Add a --skip=N option to pflash to skip N number of bytes when reading.
> This would allow users to print the VERSION partition without the STB
> header by specifying the --skip=4096 argument, and it's a more generic
> solution rather than making pflash depend on secure/trusted boot code.
>
> Signed-off-by: Adriana Kobylak <anoo at linux.ibm.com>
> ---
>  external/pflash/pflash.c | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)

Thanks, merged to master as of b6ebee077d915916989aa3057239a985981edb07.

Does it make sense to also have a --skip-stb-header option?

I don't like us relying on the stb header just being 4096 bytes, but
IIRC everywhere else hardcodes it too... I'm mostly wondering about not
building too much knowledge of host firmware into OpenBMC.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list