[Skiboot] [PATCH] lpc: Clear sync no-response field prior to device probe

Stewart Smith stewart at linux.ibm.com
Fri Oct 26 10:10:00 AEDT 2018


Andrew Jeffery <andrew at aj.id.au> writes:
> Artem Senichev reported[1] his P8 platform was failing to boot from
> a43e9a66aae9 ("astbmc: Fail SFC init if SIO is unavailable") with the
> following error:
>
> [  110.097168975,3] PLAT: Failed to open PNOR flash controller
>
> I reproduced this behaviour on a Palmetto; we need to ensure the state
> of the no-response error bit is clear before proceding with the presence
> test.
>
> The fix appears to resolve the failure to open the PNOR flash controller
> on Palmetto and doesn't change the expected behaviour on Witherspoon.
>
> [1] https://github.com/open-power/skiboot/issues/197
>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
>  hw/lpc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Thanks, and thanks to Artem and Joel for testing (and apologies for
breaking P8 things in the first place, I really need a regular OpenBMC
based P8 machine for testing).

Merged to master as of 7194e92cc700bfcc6f12f5fc12da06ef936bd2b8

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list