[Skiboot] [PATCH] Quieten 'warnings' now that SIO is disabled

Stewart Smith stewart at linux.ibm.com
Thu Oct 25 18:00:27 AEDT 2018


Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 core/pci-quirk.c          |  3 ++-
 platforms/astbmc/common.c | 11 +++++++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/core/pci-quirk.c b/core/pci-quirk.c
index 3a8583633d8a..1007e9621d71 100644
--- a/core/pci-quirk.c
+++ b/core/pci-quirk.c
@@ -34,7 +34,8 @@ static void quirk_astbmc_vga(struct phb *phb __unused,
 		mcr_scu_mpll = ast_ahb_readl(MCR_SCU_MPLL);
 		mcr_scu_strap = ast_ahb_readl(MCR_SCU_STRAP);
 	} else {
-		prlog(PR_WARNING, "Assumed platform default parameters for %s\n",
+		/* Previously we would warn, now SIO disabled by design */
+		prlog(PR_INFO, "Assumed platform default parameters for %s\n",
 		      __func__);
 		revision = bmc_platform->hw->scu_revision_id;
 		mcr_configuration = bmc_platform->hw->mcr_configuration;
diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c
index 10aed3f72901..64eba9a41e2c 100644
--- a/platforms/astbmc/common.c
+++ b/platforms/astbmc/common.c
@@ -413,8 +413,15 @@ void astbmc_early_init(void)
 			prerror("PLAT: AST IO initialisation failed!\n");
 
 		ast_setup_sio_mbox(MBOX_IO_BASE, MBOX_LPC_IRQ);
-	} else
-		prlog(PR_WARNING, "PLAT: AST SIO unavailable!\n");
+	} else {
+		/*
+		 * This may or may not be an error depending on if we set up
+		 * hiomap or not. In the old days it *was* an error, but now
+		 * with the way we configure the BMC hardware, this is actually
+		 * the not error case.
+		 */
+		prlog(PR_INFO, "PLAT: AST SIO unavailable!\n");
+	}
 
 	/* Setup UART and use it as console */
 	uart_init();
-- 
2.17.2



More information about the Skiboot mailing list