[Skiboot] [PATCH] external/mambo: Check for qtrace_utils.tcl before sourcing it

Madhavan Srinivasan maddy at linux.vnet.ibm.com
Sun Oct 21 01:49:30 AEDT 2018

Commit cb835dbdf875 ('external/mambo: conditionally source qtrace script')
added qtrace_utils.tcl sourcing in skiboot.tcl without a check to see
whether it exists in the current directory. This broke running mambo from
another directory using skiboot.tcl. Patch adds a check.

Fixes: cb835dbdf875 ('external/mambo: conditionally source qtrace script')
Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>
 external/mambo/skiboot.tcl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/external/mambo/skiboot.tcl b/external/mambo/skiboot.tcl
index 17561be2df83..545a7cca1935 100644
--- a/external/mambo/skiboot.tcl
+++ b/external/mambo/skiboot.tcl
@@ -1,6 +1,8 @@
 # need to get images path defined early
 source $env(LIB_DIR)/ppc/util.tcl
-source qtrace_utils.tcl
+if { [file exists qtrace_utils.tcl] } then {
+	source qtrace_utils.tcl
 # Call tclreadline's Loop to move to friendlier

More information about the Skiboot mailing list