[Skiboot] [PATCH v2] opal/hmi: Wakeup the cpu before reading core_fir

Stewart Smith stewart at linux.ibm.com
Tue Oct 16 18:52:26 AEDT 2018

Vaibhav Jain <vaibhav at linux.ibm.com> writes:
> When stop state 5 is enabled, reading the core_fir during an HMI can
> result in a xscom read error with xscom_read() returning an
> OPAL_XSCOM_PARTIAL_GOOD error code and core_fir value of all FFs. At
> present this return error code is not handled in decode_core_fir()
> hence the invalid core_fir value is sent to the kernel where it
> interprets it as a FATAL hmi causing a system check-stop.
> This can be prevented by forcing the core to wake-up using before
> reading the core_fir. Hence this patch wraps the call to
> read_core_fir() within calls to dctl_set_special_wakeup() and
> dctl_clear_special_wakeup().
> Suggested-by: Michael Neuling <mikey at neuling.org>
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> Signed-off-by: Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com>

Thanks! Merged to master as of 7cef472ed1fea75cc63cb0d8ac86d6a13d08517d

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list