[Skiboot] [PATCH v3 00/11] Add and integrate an IPMI flash implementation

Stewart Smith stewart at linux.ibm.com
Tue Oct 16 18:58:23 AEDT 2018


Andrew Jeffery <andrew at aj.id.au> writes:
> v3 fixes numerous :facepalm: bugs identified with op-test's
> testcases.OpTestPNOR.Skiroot test suite. We can now e.g. successfully erase and
> write flash regions. Minor things.
>
> I've also squashed this[1] drive-by patch into patch 6/11, as that's where the
> invocation of mbox_init() becomes an issue.
>
> [1] http://patchwork.ozlabs.org/patch/979471/
>
> Finally, I've reworked patch 11/11 to fix building bits under external/ (e.g.
> pflash), which was broken in v2 by failing to guard ast_sio_is_enabled().
>
> Please review!
>
> Andrew
>
> Tested on a Witherspoon:
>
> * Booted to Petitboot and through to an OS (Ubuntu 18.04)
> * Changed the system configuration in Petitboot and verified the change
>   held across reboots
> * op-test's testcases.OpTestPNOR.Skiroot passed all test cases.

After a whole bunch of messing about with OpenBMC and Hostboot and
op-test and 101 other things, series merged to master as of
a43e9a66aae9812f8790c4a9290989bb0774d2a6.

I made a few minor changes along the way as discussed on Slack - mostly
around log levels of things.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list