[Skiboot] [PATCH 2/2] hdata/i2c: Make SPD workaround more workaroundy

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Oct 12 17:09:01 AEDT 2018


On 09/24/2018 12:44 PM, Oliver O'Halloran wrote:
> We have a hack in the I2C device parser to fix up entries generated by
> hostboot for the DIMM SPD devices. For some reason they get reported as
> 128Kbit EEPROMs which is bad since those have a different I2C interface
> to an actual SPD device.
> 
> Oddly enough, the FSP also gets this wrong in a slightly different way.
> In the FSP case they are reported as a at24c04 (4Kbit) EEPROM, which
> also has a different I2C interface.
> 
> To fix both these problems for any eeprom we find on that bus to have
> the compatible string of "spd".
> 
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Looks good.

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

-Vasant



More information about the Skiboot mailing list