[Skiboot] [PATCH v3 00/11] Add and integrate an IPMI flash implementation

[Andrew Jeffery]

Hello,

v3 fixes numerous :facepalm: bugs identified with op-test's
testcases.OpTestPNOR.Skiroot test suite. We can now e.g. successfully erase and
write flash regions. Minor things.

I've also squashed this[1] drive-by patch into patch 6/11, as that's where the
invocation of mbox_init() becomes an issue.

[1] http://patchwork.ozlabs.org/patch/979471/

Finally, I've reworked patch 11/11 to fix building bits under external/ (e.g.
pflash), which was broken in v2 by failing to guard ast_sio_is_enabled().

Please review!

Andrew

Tested on a Witherspoon:

* Booted to Petitboot and through to an OS (Ubuntu 18.04)
* Changed the system configuration in Petitboot and verified the change
  held across reboots
* op-test's testcases.OpTestPNOR.Skiroot passed all test cases.

Andrew Jeffery (11):
  ipmi: Introduce registration for SEL command handlers
  core/lock: Use try_lock_caller() in lock_caller() to capture owner
  core/flash: Only lock around flashes update in flash_register()
  core/flash: Unlock around blocklevel calls in NVRAM accessors
  libflash: Add ipmi-hiomap
  astbmc: Prefer ipmi-hiomap for PNOR access
  astbmc: Remove coordinated isolation support
  lpc: Introduce generic probe capability
  astbmc: Use LPC probe calls to determine SIO presence
  platform: Restructure bmc_platform type
  astbmc: Fail SFC init if SIO is unavailable

 core/flash.c                   |  19 +-
 core/lock.c                    |   2 +-
 core/pci-quirk.c               |  21 +-
 hw/ast-bmc/ast-io.c            |  98 +---
 hw/ast-bmc/ast-sf-ctrl.c       |   3 +
 hw/ipmi/ipmi-sel.c             | 126 +++--
 hw/lpc.c                       | 216 ++++++---
 include/ast.h                  |   7 +-
 include/hiomap.h               |  68 +++
 include/ipmi.h                 |   5 +
 include/lpc-mbox.h             |  35 +-
 include/lpc.h                  |  14 +-
 include/platform.h             |  17 +-
 libflash/Makefile.inc          |   2 +-
 libflash/ipmi-hiomap.c         | 855 +++++++++++++++++++++++++++++++++
 libflash/ipmi-hiomap.h         |  28 ++
 libflash/mbox-flash.c          |   6 +
 platforms/astbmc/astbmc.h      |   9 +-
 platforms/astbmc/common.c      |  98 ++--
 platforms/astbmc/firestone.c   |   2 +-
 platforms/astbmc/garrison.c    |   2 +-
 platforms/astbmc/habanero.c    |   2 +-
 platforms/astbmc/p8dnu.c       |  11 +-
 platforms/astbmc/p8dtu.c       |  12 +-
 platforms/astbmc/p9dsu.c       |  11 +-
 platforms/astbmc/palmetto.c    |   2 +-
 platforms/astbmc/pnor.c        |  42 +-
 platforms/astbmc/romulus.c     |   2 +-
 platforms/astbmc/vesnin.c      |   2 +-
 platforms/astbmc/witherspoon.c |   2 +-
 30 files changed, 1427 insertions(+), 292 deletions(-)
 create mode 100644 include/hiomap.h
 create mode 100644 libflash/ipmi-hiomap.c
 create mode 100644 libflash/ipmi-hiomap.h

-- 
2.17.1