[Skiboot] [PATCH v2 04/11] core/flash: Unlock around blocklevel calls in NVRAM accessors

Andrew Jeffery andrew at aj.id.au
Mon Oct 8 11:06:30 AEDT 2018


On Sat, 6 Oct 2018, at 20:09, Stewart Smith wrote:
> Andrew Jeffery <andrew at aj.id.au> writes:
> > This ensures progress when we don't have interrupts available for
> > IPMI.
> 
> I gather this is because we end up not running pollers because we have
> locks held?

Yep.

> I wonder how we should document such calls, it's a semi
> decent gotcha I guess.

It's a whole lot less annoying to debug with the try_lock_caller() fix :)

But yeah, a semi-decent gotcha. Not sure how often people will run into
it though? I feel like if they do they're probably well equipped enough
to debug it.

Andrew


More information about the Skiboot mailing list