[Skiboot] [PATCH 2/8] Change ifdef around dump_fdt() to shut up static analysis

Stewart Smith stewart at linux.ibm.com
Thu Nov 29 15:28:27 AEDT 2018

This is a dumb warning from a certain static analysis tool that a
function has no effect when the ifdef that would make it have an effect
isn't defined and we replace it with a no-op impl.

Putting the #ifdef around the call just so I don't have to discount this
damn static analysis false positive every time I go and look at the

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
 core/fdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/fdt.c b/core/fdt.c
index 8fb9ad726548..ce4f66380a63 100644
--- a/core/fdt.c
+++ b/core/fdt.c
@@ -108,8 +108,6 @@ static void dump_fdt(void *fdt)
 		prlog(PR_INFO, "name: %s [%u]\n", name, off);
-static inline void dump_fdt(void *fdt __unused) { }
 static void flatten_dt_properties(void *fdt, const struct dt_node *dn)
@@ -183,7 +181,9 @@ static int __create_dtb(void *fdt, size_t len,
 		return fdt_error;
+#ifdef DEBUG_FDT
 	return 0;

More information about the Skiboot mailing list