[Skiboot] [PATCH v2] libpore: Sync p8 files, remove erroneous "IBM Confidential"
stewart at linux.ibm.com
Thu Nov 29 13:15:04 AEDT 2018
Stewart Smith <stewart at linux.ibm.com> writes:
> We also had some rogue "IBM Confidential" strings that we failed to
> remove with the original change of Copyright headers for open sourcing.
> Do this by synchronising with the hostboot copy of the code, which
> removed the Confidential string when their copyright headers changed for
> initial open sourcing of the code back in 2014. See hostboot commit
> 3bcf5b7982bb8a2d9227dbff7be4ff2ce5fec05c where the HWP copyright headers
> were updated.
> We likely missed this as we did a similar process inside the skiboot
> repository, but likely only on the (C) headers themselves.
> The libpore changes that we were missing *look* minor, but we need to
> throw some testing at them at least, as there *are* changes that we were
> We also have to make a minor modification (being sent upstream) to avoid
> a compiler warning of always false comparison (<0 on unsigned int)
> Reported-by: Dawn Sylvia <ddzubak at us.ibm.com>
> Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
> Changes since v1:
> - fix some fun build warnings because in skiboot we turn those on.
Merged (keeping Andrew's reviewed-by as it's essentially the same thing,
I would have just fixed it in merging it had I not wanted to check the
snowpatch job okayed it) to master as of 87b436c32ac86aa159b20d5c9545fd0c24a54bdd
OPAL Architect, IBM.
More information about the Skiboot