[Skiboot] [PATCH 3/4] phb4: Eliminate p->rte_cache

Andrew Donnellan andrew.donnellan at au1.ibm.com
Wed Nov 28 15:45:04 AEDT 2018


On 27/11/18 5:21 pm, Oliver O'Halloran wrote:
> In ancient times we added a caches to struct phb3 for some of the IODA
> tables which can only be accessed in-directly via XSCOM. A cache for the
> Requester Translation Table (RTT) was also added even though this is an
> in-memory table. This was carried over to PHB4 when Ben did the initial
> copy and paste, but it's still largely pointless.
> 
> There's no real need to have a second copy of the table. This patch
> removes the "cache" and changes all the users to reference the RTT
> directly if we need to. This reduces the size of the struct phb4 by
> 128KB.
> 
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list