[Skiboot] [PATCH] libpore: Sync p8 files, remove erroneous "IBM Confidential"

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Nov 27 14:41:53 AEDT 2018

On 27/11/18 11:19 am, Stewart Smith wrote:
> We also had some rogue "IBM Confidential" strings that we failed to
> remove with the original change of Copyright headers for open sourcing.
> Do this by synchronising with the hostboot copy of the code, which
> removed the Confidential string when their copyright headers changed for
> initial open sourcing of the code back in 2014. See hostboot commit
> 3bcf5b7982bb8a2d9227dbff7be4ff2ce5fec05c where the HWP copyright headers
> were updated.
> We likely missed this as we did a similar process inside the skiboot
> repository, but likely only on the (C) headers themselves.
> The libpore changes that we were missing *look* minor, but we need to
> throw some testing at them at least, as there *are* changes that we were
> missing.
> Reported-by: Dawn Sylvia <ddzubak at us.ibm.com>
> Signed-off-by: Stewart Smith <stewart at linux.ibm.com>

> --- a/libpore/p8_pore_table_static_data.c
> +++ b/libpore/p8_pore_table_static_data.c
> @@ -291,7 +293,7 @@ typedef uint32_t PoreInlineLocation;
>   /// PORE inline assembler context
>   ///
>   /// See the documentation page \ref pore_inline_assembler and the function
> -/// pore_inline_context_create() for further details.
> +/// pore_inline_context_create() for futher details.

...how are we adding more typos? hmm...

Everything else looks minor and sensible enough.

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list