[Skiboot] [PATCH] platforms/witherspoon: Make PCIe shared slot error message more informative

[Oliver]

On Thu, Nov 22, 2018 at 5:20 PM Andrew Donnellan
<andrew.donnellan at au1.ibm.com> wrote:
>
> If we're missing chips for some reason, we print a warning when configuring
> the PCIe shared slot.
>
> The warning doesn't really make it clear what "shared slot" is, and if it's
> printed, it'll come right after a bunch of messages about NPU setup, so
> let's clarify the message to explicitly mention PCI.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
>  platforms/astbmc/witherspoon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c
> index fe138991696f..0fafc87eb4c6 100644
> --- a/platforms/astbmc/witherspoon.c
> +++ b/platforms/astbmc/witherspoon.c
> @@ -184,7 +184,7 @@ static void witherspoon_shared_slot_fixup(void)
>         chip1 = next_chip(chip0);
>         if (!chip1 || next_chip(chip1)) {
>                 prlog(PR_WARNING,
> -                       "Unexpected number of chips, skipping shared slot detection\n");
> +                       "PLAT: Unexpected number of chips, skipping PCIe shared slot detection\n");

WELL PERSONALLY I THINK THAT THIS WOULD MAKE MORE SENSE IF YOU SAID
"SKIPPING DETECTION OF SHARED PCIE SLOT" AND POSSIBLY SAID SOMETHING
ABOUT MISSING A SECOND CHIP RATHER THAN "UNEXPECTED NUMBER OF CHIPS" I
MEAN REALLY, THE SYSTEM HAS TWO SOCKETS WHAT ELSE COULD IT POSSIBLY
BE????!

please fix, thank you

Oliver
Director, Paint-it-red campaign
Foundation for Bike Shed Aesthetics
Myers-Brigg Type Indicator: LOL with characteristics of WUT