[Skiboot] [PATCH] ipmi: Reduce ipmi_queue_msg_sync() polling loop time to 10ms

Stewart Smith stewart at linux.ibm.com
Mon Nov 19 11:44:42 AEDT 2018


On a plain boot, this reduces the time spent in OPAL by ~170ms on
p9dsu. This is due to hiomap (currently) using synchronous IPMI
messages.

It will also *significantly* reduce latency on runtime flash
operations, as we'll spend typically 10-20ms in OPAL rather than
100-200ms. It's not an ideal solution to that, but it's a quick
and obvious win for jitter.

Cc: stable
Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 core/ipmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/ipmi.c b/core/ipmi.c
index 6fdb9a74b41b..44623a72dbb6 100644
--- a/core/ipmi.c
+++ b/core/ipmi.c
@@ -179,7 +179,7 @@ void ipmi_queue_msg_sync(struct ipmi_msg *msg)
 	unlock(&sync_lock);
 
 	while (sync_msg == msg)
-		time_wait_ms(100);
+		time_wait_ms(10);
 }
 
 static void ipmi_read_event_complete(struct ipmi_msg *msg)
-- 
2.19.1



More information about the Skiboot mailing list