[Skiboot] [PATCH] hiomap: quieten warning on failing to move a window

Stewart Smith stewart at linux.ibm.com
Thu Nov 8 18:43:47 AEDT 2018


This isn't *necessarily* an error that we should complain loudly about.
If, for example, the BMC enforces the Read Only flag on a FFS partition,
opening a write window *should* fail, and we do indeed test this in
op-test.

Thus we deal with the error in a well known path: returning an error
code and then it's eventually a userspace problem.

Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 libflash/ipmi-hiomap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libflash/ipmi-hiomap.c b/libflash/ipmi-hiomap.c
index e2b64fe9c065..ac47a1005ef8 100644
--- a/libflash/ipmi-hiomap.c
+++ b/libflash/ipmi-hiomap.c
@@ -277,7 +277,7 @@ static bool hiomap_window_move(struct ipmi_hiomap *ctx, uint8_t command,
 	ipmi_queue_msg_sync(msg);
 
 	if (res.cc != IPMI_CC_NO_ERROR) {
-		prerror("%s failed: %d\n", __func__, res.cc);
+		prlog(PR_INFO, "%s failed: %d\n", __func__, res.cc);
 		return false;
 	}
 
-- 
2.19.1



More information about the Skiboot mailing list