[Skiboot] [PATCH] phb4/capp: Only reset FIR bits that cause capp machine check

Stewart Smith stewart at linux.ibm.com
Fri Nov 2 19:01:50 AEDT 2018


Vaibhav Jain <vaibhav at linux.ibm.com> writes:
> During CAPP recovery do_capp_recovery_scoms() will reset the CAPP Fir
> register just after CAPP recovery is completed. This has an
> unintentional side effect of preventing PRD from analyzing and
> reporting this error. If PRD tries to read the CAPP FIR after opal has
> already reset it, then it logs a critical error complaining "No active
> error bits found".
>
> To prevent this from happening we update do_capp_recovery_scoms() to
> only reset fir bits that cause CAPP machine check (local xstop). This
> is done by reading the CAPP Fir Action0/1 & Mask registers and
> generating a mask which is then written on CAPP_FIR_CLEAR register.
>
> Cc: stable
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>

Cheers, Merged to master as of 999246716d2da347aad46a28ed9899b832bffe6c
and into 6.0.x as of bf93742f5c047082a759dda6799e42808e2f9135 for 6.0.11

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list