[Skiboot] [PATCH v2 3/5] npu2-opencapi: Train links on fundamental reset

Andrew Donnellan andrew.donnellan at au1.ibm.com
Thu May 31 18:17:59 AEST 2018

On 24/05/18 03:25, Frederic Barrat wrote:
> From: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
> Reorder our link training steps so that they are executed on
> fundamental reset instead of during the initial setup. Skiboot always
> call a fundamental reset on all the PHBs during pci init.
> It is done through a state machine, similarly to what is done for
> 'real' PHBs.
> This is the first step for a longer term goal to be able to trigger an
> adapter reset from linux. We'll need the reset callbacks of the PHB to
> be defined. We have to handle the various delays differently, since a
> linux thread shouldn't stay stuck waiting in opal for too long.
> No functional changes.
> Signed-off-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>

Acked-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> ---
> v2:
> 	Fence/unfence the OTL on reset, except during initial startup,
> 	where it is useless. It is to protect us for later, when the
> 	OS can trigger an adapter reset, as a FIR bit is raised if the
> 	link goes down and the OTL is not fenced.
Is there any reason to *not* fence on the initial startup?

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list