[Skiboot] [PATCH 2/2] core: Implement non-FSP dump region opal call

[Vasant Hegde]

On 05/28/2018 09:16 AM, Joel Stanley wrote:
> On 25 May 2018 at 15:46, Vasant Hegde <hegdevasant at linux.vnet.ibm.com> wrote:
>> On 05/24/2018 07:07 AM, Joel Stanley wrote:

.../...

> 
> I've named it after the opal call that it implements.
> 
> I don't think there's anything wrong with having fsp-sysdump (or even
> fsp-dump-region), as it's pretty clear what is going on.
> 
> I'd suggest we name things after the opal/skiboot features they
> implement, and if there are external features that use these features
> that's fine, but it doesn't need to influcence the naming. (For
> example, I didn't call this file pdbg-dmesg, even though that's what
> the first user will be).
> 
> An enhancement that could be made here is to have the one
> dump-region.c that registers the debug descriptor for all platforms,
> and if it's on FSP also calls into the mdst/sysdump platform code. I
> played with this idea but the code didn't come out very clean, so it
> would require more effort

I had thought about this when I reviewed this patch. But the way we use dump 
region is
completely different here. Also we don't run pdgb on FSP anyway. So current code 
is fine
for now. And if we need, we can create platform specific hooks later.


> 
>>>    core/init.c               |  2 ++
>>>    include/dump.h            | 26 +++++++++++++++++
>>
>>
>> Better rename this  as dump-region.h or just move declaration to skiboot.h
>> itself?
> 
> I'll rename it.

Cool.

-Vasant