[Skiboot] [PATCH v2] SLW: Remove stop1_lite and stop2_lite
stewart at linux.vnet.ibm.com
Mon May 28 17:44:51 AEST 2018
Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com> writes:
> * Stewart Smith <stewart at linux.vnet.ibm.com> [2018-05-25 10:26:21]:
>> Akshay Adiga <akshay.adiga at linux.vnet.ibm.com> writes:
>> > stop1_lite has been removed since it adds no additional benefit
>> > over stop0_lite. stop2_lite has been removed since currently it adds
>> > minimal benefit over stop2. However, the benefit is eclipsed by the time
>> > required to ungate the clocks
>> > Moreover, Lite states don't give up the SMT resources, can potentially
>> > have a performance impact on sibling threads.
>> > Signed-off-by: Akshay Adiga <akshay.adiga at linux.vnet.ibm.com>
>> > ---
>> > hw/slw.c | 36 ++++++++----------------------------
>> > 1 file changed, 8 insertions(+), 28 deletions(-)
>> As discussed on phone, I've merged this into master as of
>> 34e9c3c1edb3eed02f428f9cbf97d99b3db43d4d and we can work on getting
>> things back and having smarter kernel and firmware over the next few
>> I gather this should also head to stable so that it ends up in customer
>> hands in a timely fashion?
> Hi Stewart,
> Thanks a lot. Yes, once the kernel gets smarter we should add some of
> these back.
> This should go to stable for P9 customers and builds. Not needed for
> older stable branches of skiboot.
Ack. Cherry-picked into 6.0.x as of
cc52c56200956485aee67cb933b2a3d0132cc7fd, and I'll go tag a 6.0.4 with
OPAL Architect, IBM.
More information about the Skiboot