[Skiboot] [PATCH v3] platform/astbmc: Do not delete compatible property

Stewart Smith stewart at linux.ibm.com
Fri May 25 09:02:25 AEST 2018

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> P9 onwards OPAL is building device tree for BMC based system using
> HDAT. We are populating bmc/compatible node with bmc version. Hence
> do not delete this property.
> CC: Jeremy Kerr <jk at ozlabs.org>
> CC: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

This does get us properties like this though:
compatible       "ibm,ast2500,supermicro"
compatible       "ibm,ast2500,openbmc"

which... are certainly wrong. This is, however, what HDAT is giving us,
so arguably this is a HDAT bug.

In fact, this even violates the HDAT spec, which says:

P9 IBM systems with FSP: ibm,fsp2,fips
P9 IBM systems with BMC: ibm,ast2500,openbmc
P9 IBM systems with SuperMicro: supermicro,ast2500,aten

which is not what we get, we seem to always get what I pasted above (for
p9dsu and witherspoon respectively).

Soo... what should we do about that? While the second comma in the
compatible property is odd, it doesn't seem to violate the DT spec.

I'm okay with merging this as-is, as long as we fix up the oddities in a
subsequent patch though. So, it's in master as of

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list