[Skiboot] [PATCH 4/9] ipmi-watchdog: Don't disable at shutdown

William A. Kennington III wak at google.com
Thu May 24 10:13:30 AEST 2018


The op-build linux kernel has been configured to support the ipmi
watchdog. This driver will always handle the watchdog by either leaving
it enabled if configured, or by disabling it during module load if no
configuration is provided. This increases the coverage of the watchdog
during the boot process. The watchdog should no longer be disabled at
any point during skiboot execution.

Signed-off-by: William A. Kennington III <wak at google.com>
---
 hw/ipmi/ipmi-watchdog.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/ipmi/ipmi-watchdog.c b/hw/ipmi/ipmi-watchdog.c
index e8efba2b4..b5cb5fee4 100644
--- a/hw/ipmi/ipmi-watchdog.c
+++ b/hw/ipmi/ipmi-watchdog.c
@@ -121,14 +121,9 @@ void ipmi_wdt_stop(void)
 
 void ipmi_wdt_final_reset(void)
 {
-	/* todo: this is disabled while we're waiting on fixed watchdog
-	 * behaviour */
-#if 0
 	set_wdt(WDT_RESET_ACTION | WDT_PRETIMEOUT_SMI, WDT_TIMEOUT,
 		WDT_MARGIN/10, true);
-	reset_wdt(NULL, (void *) 1);
-#endif
-	set_wdt(WDT_NO_ACTION, 100, 0, false);
+	sync_reset_wdt();
 	ipmi_set_boot_count();
 	cancel_timer(&wdt_timer);
 }
-- 
2.17.0.441.gb46fe60e1d-goog



More information about the Skiboot mailing list