[Skiboot] [PATCH 0/9] ipmi-watchdog: Fixes for error handling and general cleanups

William A. Kennington III wak at google.com
Thu May 24 10:13:26 AEST 2018


The current watchdog implementation doesn't do a good job of handling
error cases when the BMC side restarts or crashes. This set of patches
tries to improve the robustness of the ipmi watchdog code such that
recovery happens when possible.

This series also adds a patch which enables the watchdog for the KEXEC
payload since the kernel being executed is guaranteed to support handling
the watchdog.

It also adds some general cleanups to the code that made the above
easier to implement.

William A. Kennington III (9):
  ipmi-watchdog: WD_POWER_CYCLE_ACTION -> WD_RESET_ACTION
  ipmi-watchdog: Make it possible to set DONT_STOP
  ipmi-watchdog: Don't reset the watchdog twice
  ipmi-watchdog: Don't disable at shutdown
  ipmi-watchdog: Add a flag to determine if we are still ticking
  ipmi-watchdog: The stop action should disable reset
  ipmi-watchdog: Simplify our completion function
  ipmi-watchdog: Support resetting the watchdog after set
  ipmi-watchdog: Support handling re-initialization

 hw/ipmi/ipmi-watchdog.c | 126 +++++++++++++++++++++++++++++++---------
 1 file changed, 98 insertions(+), 28 deletions(-)

-- 
2.17.0.441.gb46fe60e1d-goog



More information about the Skiboot mailing list