[Skiboot] [PATCH 3/3] Romulus: default to OpenBMC
Vasant Hegde
hegdevasant at linux.vnet.ibm.com
Mon May 21 19:17:14 AEST 2018
On 05/16/2018 04:20 AM, Stewart Smith wrote:
> Suggested-by: Joseph Reynolds <jrey at us.ibm.com>
> Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
> ---
> platforms/astbmc/romulus.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/platforms/astbmc/romulus.c b/platforms/astbmc/romulus.c
> index 7cdc3b9d3669..357ab30a594b 100644
> --- a/platforms/astbmc/romulus.c
> +++ b/platforms/astbmc/romulus.c
> @@ -74,7 +74,12 @@ DECLARE_PLATFORM(romulus) = {
> .init = astbmc_init,
> .start_preload_resource = flash_start_preload_resource,
> .resource_loaded = flash_resource_loaded,
> - .bmc = NULL, /* FIXME: Add openBMC */
> + /*
> + * Defaults to OpenBMC, if there's ever differences on the BMC
> + * implementation between AMI BMC and OpenBMC, then this'll have
> + * to get smart
That time we can rely on bmc/compatible property (like ibm,ast2500,openbmc) and
fix it.
Between looks like you never pulled my fix to get compatible property. Can you
pull this one?
https://lists.ozlabs.org/pipermail/skiboot/2017-April/006862.html
-Vasant
> + */
> + .bmc = &astbmc_openbmc,
> .pci_get_slot_info = slot_table_get_slot_info,
> .pci_probe_complete = check_all_slot_table,
> .cec_power_down = astbmc_ipmi_power_down,
>
More information about the Skiboot
mailing list