[Skiboot] [PATCH] SLW: Remove stop1_lite and stop2_lite
Akshay Adiga
akshay.adiga at linux.vnet.ibm.com
Thu May 17 15:26:38 AEST 2018
On Tue, May 15, 2018 at 05:21:04PM +1000, Nicholas Piggin wrote:
> On Tue, 15 May 2018 12:08:31 +0530
> Akshay Adiga <akshay.adiga at linux.vnet.ibm.com> wrote:
>
> > On Thu, May 10, 2018 at 02:15:57PM +0530, Akshay Adiga wrote:
> > > Lite states don't give up the SMT resources, can potentially have a
> > > performance impact on sibling threads. At latencies of stop1_lite
> > > and stop2_lite , lite states dont make sense and can have
> > > performance impact.
> > >
> > > Signed-off-by: Akshay Adiga <akshay.adiga at linux.vnet.ibm.com>
> > >
> >
> > This is a followup on the previous patch :
> > https://patchwork.ozlabs.org/patch/906582/
> >
> > Nick,Stewart does this look good ?
> >
>
> Yes I think so. The rest we can look at tuning with Linux and dt
> parameters, but I think this should avoid most of the pathological
> cases and work with existing kernels, without overly hard coding
> policy.
>
> I would add a comment as to why we're leaving those states out
> though.
I dont have problem adding a comment. But it will be like adding a
comment for the code that does removed code. Anyways, we have the
the reason mentioned in git log.
>
> Thanks,
> Nick
>
More information about the Skiboot
mailing list