[Skiboot] [PATCH] p9dsu: detect variant in init only if probe fails to found.

[ppaidipe]

On 2018-05-12 01:37, Stewart Smith wrote:
> ppaidipe <ppaidipe at linux.vnet.ibm.com> writes:
>> On 2018-05-11 11:41, Michael Neuling wrote:
>>> On Fri, 2018-05-11 at 01:56 +0530, Pridhiviraj Paidipeddi wrote:
>>>> Currently the slot table init happens twice in both probe and init
>>>> functions due to the variant detection logic called with in-correct
>>>> condition check.
>>>> 
>>>> Fixes: d32ddea9 ("p9dsu: detect p9dsu variant even when hostboot
>>>> doesn't tell us")
>>>> 
>>>> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
>>>> ---
>>>>  platforms/astbmc/p9dsu.c | 10 ++++++++--
>>>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>>> 
>>>> diff --git a/platforms/astbmc/p9dsu.c b/platforms/astbmc/p9dsu.c
>>>> index e4fef5e..ead693f 100644
>>>> --- a/platforms/astbmc/p9dsu.c
>>>> +++ b/platforms/astbmc/p9dsu.c
>>>> @@ -28,6 +28,8 @@
>>>> 
>>>>  #include "astbmc.h"
>>>> 
>>>> +static bool variant_found = false;
>>> 
>>> Can you call this something more descriptive than just "variant"?
>>> 
>> 
>> How about p9dsu_riser_found?
> 
> I think that's okay - I did the change and merged to master as of
> d6317227c2d1b0ddbb331c250729d8a3b07180d1

Thanks.