[Skiboot] [RESEND-PATCH] core/opal: Fix recursion check in opal_run_pollers()

Stewart Smith stewart at linux.vnet.ibm.com
Sat May 12 06:03:46 AEST 2018

Vaibhav Jain <vaibhav at linux.ibm.com> writes:
> An earlier commit introduced a counter variable poller_recursion to
> limit to the number number of error messages shown when opal_pollers
> are run recursively. However the check for the counter value was
> placed in a way that the poller recursion was only detected first 16
> times and then allowed afterwards.
> This patch fixes this by moving the check for the counter value inside
> the conditional branch with some re-factoring so that opal_poller
> recursion is not erroneously allowed after poll_recursion is detected
> first 16 times.
> Fixes: b6a729e118f4 ("Limit number of Poller recursion detected errors to display")
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
> Changelog:
> Resend -> Previous patch didn't make to the skiboot mailing list due to
>        	  a list membership glitch.
> ---
>  core/opal.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

thanks! Merged to master as of 92d1a4e923fa427ab73f52850381b08c1bcf5676

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list