[Skiboot] [PATCH] external/mambo: simplify implementation of di
Balbir singh
bsingharora at gmail.com
Wed May 2 20:51:39 AEST 2018
We've got a great disassembly function built-in, reuse
that to implement di (as in xmon).
Improves 1bcd6d84: (external/mambo: Add di command to decode instructions)
Signed-off-by: Balbir singh <bsingharora at gmail.com>
---
external/mambo/mambo_utils.tcl | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/external/mambo/mambo_utils.tcl b/external/mambo/mambo_utils.tcl
index b503acbf..ce5bcccb 100644
--- a/external/mambo/mambo_utils.tcl
+++ b/external/mambo/mambo_utils.tcl
@@ -158,15 +158,9 @@ proc ex { ea { size 8 } } {
puts "$pa : $val"
}
-proc di { location { count 16 } } {
- set addr [expr $location & 0xfffffffffffffff0]
- set top [expr $addr + ($count * 4)]
- for { set i $addr } { $i < $top } { incr i 4 } {
- set pc_laddr [mysim cpu 0 util itranslate $i]
- set inst [mysim cpu 0 memory display $pc_laddr 4]
- set disasm [mysim cpu 0 util ppc_disasm $inst $i]
- puts "$pc_laddr: Enc:$inst : $disasm"
- }
+proc di { location { count 16 } } {
+ set addr [expr $location & 0xfffffffffffffff0]
+ disasm_mem mysim $addr $count
}
proc hexdump { location count } {
--
2.17.0
More information about the Skiboot
mailing list