[Skiboot] [PATCH 2/2] hw/imc: don't access homer memory if it was not initialised

Stewart Smith stewart at linux.vnet.ibm.com
Wed Mar 28 14:25:33 AEDT 2018


Nicholas Piggin <npiggin at gmail.com> writes:
> This can happen under mambo, at least.
>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>  hw/imc.c | 3 +++
>  1 file changed, 3 insertions(+)


>
> diff --git a/hw/imc.c b/hw/imc.c
> index 5bc59b59..c7999e1e 100644
> --- a/hw/imc.c
> +++ b/hw/imc.c
> @@ -154,6 +154,9 @@ static struct imc_chip_cb *get_imc_cb(uint32_t chip_id)
>  	struct proc_chip *chip = get_chip(chip_id);
>  	struct imc_chip_cb *cb;
>  
> +	if (!chip->homer_base)
> +		return NULL; /* The No Homers Club */
> +

We're still allowed one right? :)

Merged to master as of 103f67fe83f1f42fe200a60faa053add0282cc8b

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list