[Skiboot] [PATCH] phb*: Remove the state field in the various phb structures

Stewart Smith stewart at linux.vnet.ibm.com
Fri Mar 23 16:44:30 AEDT 2018


Oliver O'Halloran <oohall at gmail.com> writes:
> We've been carting around this field since the original p7ioc-phb code.
> As far as I can tell we never actually use it for anything other than
> checking if the PHB has been marked as broken or not. The _FENCED
> state is set in a few places, but we never use it in favour of just
> checking the MMIO register.
>
> This patch just replaces it with a boolean that indicates if
> the PHB has been marked as broken and removes the giant, mostly
> wrong, comment explaining it's usage that is copied and pasted
> into each phb header file.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Merged to master as of 3e74805702f6216ac550708dc0f23ceb15c95bc3
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list