[Skiboot] [PATCH] xive: fix opal_xive_set_vp_info() error path

Cédric Le Goater clg at kaod.org
Thu Mar 22 04:12:37 AEDT 2018


In case of error, opal_xive_set_vp_info() will return without
unlocking the xive object. This is most certainly a typo.

Signed-off-by: Cédric Le Goater <clg at kaod.org>
---
 hw/xive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xive.c b/hw/xive.c
index dff94ab839e1..468e5b0446e9 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -4385,8 +4385,8 @@ static int64_t opal_xive_set_vp_info(uint64_t vp_id,
 	if (!(flags & OPAL_XIVE_VP_ENABLED))
 		xive_vpc_scrub_clean(x, blk, idx);
 
-	unlock(&x->lock);
 bail:
+	unlock(&x->lock);
 	return rc;
 }
 
-- 
2.13.6



More information about the Skiboot mailing list