[Skiboot] [PATCH v3] capi: Poll Err/Status register during CAPP recovery

Vaibhav Jain vaibhav at linux.vnet.ibm.com
Mon Mar 19 15:32:45 AEDT 2018

Hey Alastair,

Thanks for looking into this patch:

Alastair D'Silva <alastair at au1.ibm.com> writes:

>> +	/* No recovery in progress ignore */
>> +	if ((reg & PPC_BIT(0)) == 0) {
>> +		PHBDBG(p, "CAPP: No recovery in progress\n");
>> +		return 0;
> Did you mean OPAL_SUCCESS here? Other return points in the function use
> the OPAL_* macros.
Good catch. Will include this change in next revision.
Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.

More information about the Skiboot mailing list