[Skiboot] [PATCH] npu2: Remove DD1 support

Balbir Singh bsingharora at gmail.com
Sat Mar 17 09:17:22 AEDT 2018


On Fri, Mar 16, 2018 at 2:10 PM, Andrew Donnellan
<andrew.donnellan at au1.ibm.com> wrote:
> Major changes in the NPU between DD1 and DD2 necessitated a fair bit of
> revision-specific code.
>
> Now that all our lab machines are DD2, we no longer test anything on DD1
> and it's time to get rid of it.
>
> Remove DD1-specific code and abort probe if we're running on a DD1 machine.
>  void probe_npu2(void)
>  {
> +       struct proc_chip *chip = next_chip(NULL);
>         struct dt_node *np;
>         const char *zcal;
>
> +       /* Abort if we're running on DD1 */
> +       if (chip &&
> +           (chip->type == PROC_CHIP_P9_NIMBUS ||
> +            chip->type == PROC_CHIP_P9_CUMULUS) &&
> +           (chip->ec_level & 0xf0) == 0x10) {
> +               prlog(PR_INFO, "NPU2: DD1 not supported\n");

I'm nitpicking, but I'd prefer if we say "no longer supported", to
indicate that it was in the past

Otherwise

Acked-by: Balbir Singh <bsingharora at gmail.com>


More information about the Skiboot mailing list