[Skiboot] [PATCH 1/3] core/opal: abort in case of re-entrant OPAL call

Nicholas Piggin npiggin at gmail.com
Fri Mar 16 21:15:15 AEDT 2018


The stack is already destroyed by the time we get here, so there
is not much point continuing.

Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 core/opal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/opal.c b/core/opal.c
index 9bf2ad84..e7940e7a 100644
--- a/core/opal.c
+++ b/core/opal.c
@@ -145,7 +145,7 @@ int64_t opal_entry_check(struct stack_frame *eframe)
 	if (!opal_quiesce_state && cpu->in_opal_call) {
 		printf("CPU ATTEMPT TO RE-ENTER FIRMWARE! PIR=%04lx cpu @%p -> pir=%04x token=%llu\n",
 		       mfspr(SPR_PIR), cpu, cpu->pir, token);
-		return OPAL_BUSY;
+		abort();
 	}
 
 again:
-- 
2.16.1



More information about the Skiboot mailing list