[Skiboot] [PATCH] dts: spl_wakeup: Remove all workarounds in the spl wakeup logic

Vaidyanathan Srinivasan svaidy at linux.vnet.ibm.com
Thu Mar 15 21:14:00 AEDT 2018

* Stewart Smith <stewart at linux.vnet.ibm.com> [2018-03-15 20:13:45]:

> Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
> > We coded few workarounds in special wakeup logic to handle the
> > buggy firmware. Now that is fixed remove them as they break the
> > special wakeup protocol. As per the spec we should not de-assert
> > beofre assert is complete. So follow this protocol.
> >
> > Signed-off-by: Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com>
> > ---
> >  core/direct-controls.c | 59 +++++++++++++++++++++++++-------------------------
> >  hw/dts.c               | 30 +------------------------
> >  2 files changed, 30 insertions(+), 59 deletions(-)
> great! Merged to master as of b5c9d09d067743be6ab12eef49f80562f0d41f02
> Is it worth trying re-enabling stop4 and stop5 now? Was this one of the
> issues causing failures there?

This patch helped capture CME/microcode issues at the first fail, then
root-caused and fixed. The HCODE has to roll out into a release before
we can re-enable stop4/5.  Special wakeup with stop4/5 has been stress
tested with the new HCODE that is yet to release.

Further we are removing DTS reads in favour of OCC sensors in the
other patch to avoid poking cores.


More information about the Skiboot mailing list