[Skiboot] [PATCH] Don't detect lock timeouts when timebase is invalid

Stewart Smith stewart at linux.vnet.ibm.com
Tue Mar 13 15:12:23 AEDT 2018

Oliver <oohall at gmail.com> writes:
> On Fri, Mar 9, 2018 at 4:47 PM, Stewart Smith
> <stewart at linux.vnet.ibm.com> wrote:
>> We can have threads waiting on hmi_lock who have an
>> invalid timebase. Because of this, we want to go poke
>> the register directly rather than rely on
>> this_cpu()->tb_invalid (which won't have been set yet).
> Maybe we should just switch the polarity of tb_invalid to tb_valid
> instead?

possibly? Either way, there's going to be a window where it's lies.

I do kind of like the "if (this_cpu()->tb_valid)" pattern more than the
invalid one.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list