[Skiboot] [PATCH] npu2: Use unfiltered mode in XTS tables

[Reza Arbab]

On Fri, Mar 09, 2018 at 10:33:51AM +1100, Alistair Popple wrote: 
>> -static int opal_npu_destroy_context(uint64_t phb_id, uint64_t pid, uint64_t bdf)
>> +static int opal_npu_destroy_context(uint64_t phb_id, uint64_t pid __unused,
>> +				    uint64_t bdf)
>>  {
>>  	struct phb *phb = pci_get_phb(phb_id);
>>  	struct npu2 *p = phb_to_npu2(phb);
>> -	uint64_t xts_bdf, xts_bdf_pid;
>> -	uint64_t lparshort;
>> -	int id, rc = 0;
>> +	uint64_t xts_bdf;
>> +	int rc = 0;
>>
>>  	if (!phb || phb->phb_type != phb_type_npu_v2)
>>  		return OPAL_PARAMETER;
>> @@ -2137,26 +2136,13 @@ static int opal_npu_destroy_context(uint64_t phb_id, uint64_t pid, uint64_t bdf)
>>  			     &xts_bdf, NPU2_XTS_BDF_MAP_BDF) < 0) {
>>  		NPU2ERR(p, "LPARID not associated with any GPU\n");
>
>I guess this check is still somewhat useful to catch a buggy device driver out
>but I'm not convinced it provides much value - we could just as easily remove it
>as well.

Yeah, I wavered on it a bit and figured if nothing else, the function 
could still keep validating that argument. There are some words to that 
effect in the commit log.

-- 
Reza Arbab