[Skiboot] [PATCH v2 0/5] libflash blocklevel ECC corrections

[Samuel Mendoza-Jonas]

On Wed, 2018-03-07 at 17:04 +1100, Cyril Bur wrote:
> V1 was submitted almost a year ago:
> https://lists.ozlabs.org/pipermail/skiboot/2017-April/006977.html
> 
> The core of the problem still exists, this problem does still need to
> get addressed in blocklevel rather than individually in each tool.
> 
> I've rebased this onto master and double checked that everything
> still appears to work.
> 
> Both the gard tool and pflash built with this series have are:
> Tested-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
> 
> Stewart, I'm not sure if this means we should put the tag on all
> patches or just the last one. I've put it on the last one because
> that makes the most sense to me.

Reviewed-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>

And heavily endorsed since bugs due to this were a huge pain to debug :)
Essentially we can never turn ECC back on for NVRAM without these changes
since the Linux kernel will try to write the lnx,oops-log partition at an
unaligned address.

> 
> 
> Cyril Bur (5):
>   gitignore: Add stb test kernel files
>   libflash/ecc: Add functions to deal with unaligned ECC memcpy
>   libflash/ecc: Add helpers to align a position within an ecc buffer
>   libflash/blocklevel: Return region start from ecc_protected()
>   libflash/blocklevel: Make read/write be ECC agnostic for callers
> 
>  .gitignore                      |   3 +
>  external/gard/gard.c            |  49 +++---
>  libflash/blocklevel.c           | 137 ++++++++++++++---
>  libflash/ecc.c                  | 247 +++++++++++++++++++++++++++---
>  libflash/ecc.h                  |   9 ++
>  libflash/test/test-blocklevel.c | 330 +++++++++++++++++++++++++++++++++++-----
>  libflash/test/test-ecc.c        |  31 ++++
>  7 files changed, 701 insertions(+), 105 deletions(-)
>