[Skiboot] [PATCH] capp: Make error in capp timebase sync a non-fatal error

Stewart Smith stewart at linux.vnet.ibm.com
Wed Mar 7 14:39:39 AEDT 2018

Vaibhav Jain <vaibhav at linux.vnet.ibm.com> writes:
> Presently when we encounter an error while synchronizing capp timebase
> with chip-tod at the end of enable_capi_mode() we return an
> error. This has an to unintended consequences. First this will prevent
> disabling of fast-reboot even though CAPP is already enabled by this
> point. Secondly, failure during timebase sync is a non fatal error or
> capp initialization as CAPP/PSL can continue working after this and an
> AFU will only see an error when it tries to read the timebase value
> from PSL.
> So this patch updates enable_capi_mode() to not return an error in
> case call to chiptod_capp_timebase_sync() fails. The function will now
> just log an error and continue further with capp init sequence. This
> make the current implementation align with the one in kernel 'cxl'
> driver which also assumes the PSL timebase sync errors as non-fatal
> init error.
> Signed-off-by: Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
> ---
>  hw/phb4.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Merged to master as of a72d055d93378e934df38a4bb1787e427fbf21cf

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list