[Skiboot] [PATCH v2] npu2-opencapi: Fix assert on link reset during init

Stewart Smith stewart at linux.vnet.ibm.com
Wed Mar 7 14:38:59 AEDT 2018

Frederic Barrat <fbarrat at linux.vnet.ibm.com> writes:
> We don't support resetting an opencapi link yet.
> Commit fe6d86b9 ("pci: Make fast reboot creset PHBs in parallel")
> tries resetting any PHB whose slot defines a 'run_sm' callback. It
> raises an assert when applied to an opencapi PHB, as 'run_sm' calls
> the 'freset' callback, which is not yet defined for opencapi.
> Fix it for now by removing the currently useless definition of
> 'run_sm' on the opencapi slot. It will print a message in the skiboot
> log because the PHB cannot be reset, which is correct. It will all go
> away when we add support for resetting an opencapi link.
> Signed-off-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
> ---
> v2:
> 	add comment
>  hw/npu2-opencapi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Thanks, merged to master as of 48dd5f7b9fbba52f08cd991d3443748dd810a99b

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list