[Skiboot] [PATCH] pci: Reduce log level of error message

Michael Neuling mikey at neuling.org
Tue Mar 6 17:10:55 AEDT 2018

If a link doesn't train, we can end up with error messages like this:

[   63.027261959,3] PHB#0032[8:2]: LINK: Timeout waiting for electrical link
[   63.027265573,3] PHB#0032:00:00.0 Error -6 resetting

The first message is useful but the second message is just debug from
the core PCI code and is confusing to print to the console.

This reduces the second print to debug level so it's not seen by the
console by default.

Signed-off-by: Michael Neuling <mikey at neuling.org>
Reported-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
 core/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/pci.c b/core/pci.c
index 982012f828..3fc4854a3e 100644
--- a/core/pci.c
+++ b/core/pci.c
@@ -987,7 +987,7 @@ static void pci_reset_phb(void *data)
 	pci_slot_remove_flags(slot, PCI_SLOT_FLAG_BOOTUP);
 	if (rc < 0)
-		PCIERR(phb, 0, "Error %lld resetting\n", rc);
+		PCIDBG(phb, 0, "Error %lld resetting\n", rc);
 static void pci_scan_phb(void *data)

More information about the Skiboot mailing list