[Skiboot] [PATCH v2] Tie tm-suspend fw-feature and opal_reinit_cpus() together

Stewart Smith stewart at linux.vnet.ibm.com
Tue Mar 6 14:18:18 AEDT 2018

Michael Neuling <mikey at neuling.org> writes:
> Currently opal_reinit_cpus(OPAL_REINIT_CPUS_TM_SUSPEND_DISABLED)
> always returns OPAL_UNSUPPORTED.
> This ties the tm suspend fw-feature to the
> opal_reinit_cpus(OPAL_REINIT_CPUS_TM_SUSPEND_DISABLED) so that when tm
> suspend is disabled, we correctly report it to the kernel.  For
> backwards compatibility, it's assumed tm suspend is available if the
> fw-feature is not present.
> Currently hostboot will clear fw-feature(TM_SUSPEND_ENABLED) on P9N
> DD2.1. P9N DD2.2 will set fw-feature(TM_SUSPEND_ENABLED).  DD2.0 and
> below has TM disabled completely (not just suspend).
> We are using opal_reinit_cpus() to determine this setting (rather than
> the device tree/HDAT) as some future firmware may let us change this
> dynamically after boot. That is not the case currently though.
> Signed-off-by: Michael Neuling <mikey at neuling.org>
> Reviewed-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
> v2:
>   Update commit message based on Cyril's comments
> ---
>  core/cpu.c | 27 ++++++++++++++++++++++-----
>  1 file changed, 22 insertions(+), 5 deletions(-)

merged to master as of 730bccbbb6154bd9bf7e98d3fcb121521f325996
and to 5.10.x as of ee7497e443923d548362b8b5b8ef8d05f1164363

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list