[Skiboot] [PATCH] console(lpc/fsp-console): Use just stdout-path.

Stewart Smith stewart at linux.vnet.ibm.com
Mon Mar 5 09:54:51 AEDT 2018


Michael Ellerman <mpe at ellerman.id.au> writes:
> Oliver <oohall at gmail.com> writes:
>
>> On Fri, Mar 2, 2018 at 4:10 AM, ppaidipe <ppaidipe at linux.vnet.ibm.com> wrote:
>>> On 2018-03-01 12:36, Stewart Smith wrote:
>>>>
>>>> Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com> writes:
>>>>>
>>>>> dtc tool complaining about below warning as usage of linux,stdout-path
>>>>> property under /chosen node is deprecated.
>>
>> Hmm, dtc is largely intended for the embedded community who have the
>> ability to fix up the DTB to better match what a specific kernel
>> versions expects while we don't have that luxury.
>
> That's not universally true even for embedded folks, in some cases the
> DTB is tied to the boot loader, not the kernel. Though some of the
> people doing that would not expect to update the kernel ever.
>
>> We need to ensure old kernels will continue to boot with a newer
>> skiboot so we're forced to keep the "deprecated" parts of the DT
>> around. IMO the warning is kind of bogus for our situation so we might
>> want to look at adding a switch to dtc so that it complains less about
>> this sort of issue.
>
> Yeah, we should try to update when we can, but we need to be careful.
>
> This patch could have broken a bunch of old kernels, which we may not
> have noticed for a while, and which would have been hard to debug, just
> to squelch a dubious warning.

Yeah... colour me terrified of such subtle breakages - and we're not
really set up well to test that yet.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list