[Skiboot] [PATCH v8 1/2] phb4: set PHB CMPM registers for tunneled operations

Stewart Smith stewart at linux.vnet.ibm.com
Fri Mar 2 15:03:51 AEDT 2018

Philippe Bergheaud <felix at linux.vnet.ibm.com> writes:
> P9 supports PCI tunneled operations (atomics and as_notify) that require
> setting the PHB ASN Compare/Mask register with a 16-bit indication.
> This register is currently initialized by enable_capi_mode(). But, as
> tunneled operations may also work in PCI mode, the ASN Compare/Mask
> register should rather be initialized in phb4_init_ioda3().
> This patch also adds "ibm,phb-indications" to the device tree, to tell
> Linux the values of CAPI, ASN, and NBW indications, when supported.
> Tunneled operations tested by IBM in CAPI mode, by Mellanox Technologies
> in PCI mode.
> Signed-off-by: Philippe Bergheaud <felix at linux.vnet.ibm.com>
> Reviewed-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
> ---
> Changelog:
> v2: Do not let Linux choose indication values.
>     Let skiboot tell Linux via the device tree.
>     Initialize the PHB ASN indication in PCI mode.
> v3: No functional change.
>     Drop cosmetic fixes in comments.
> v4: No change.
> v5: Set bit 59 of ASN indication and mask, as required for as_notify,
>     in order to prevent address translation on lpid,pid,tid messages,
>     that are not real addresses.
> v6: No change.
> v7: Explain those indicator and mask values, with comments kindly
>     supplied by Frederic Barrat.
>     Remove tests for dd1 in new code, as nobody in the capi galaxy
>     is using dd1 any more.
> v8: No change.
> ---
>  hw/phb4.c           | 49 ++++++++++++++++++++++++++++++++++++++++++-------
>  include/phb4-regs.h |  4 ++--
>  2 files changed, 44 insertions(+), 9 deletions(-)

Thanks! Series merged to master as of 0f3584d846629d5bc1832a1dc4663a1befe8c4b0

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list