[Skiboot] [PATCH] core: Fix 'opal-runtime-size' property

Stewart Smith stewart at linux.vnet.ibm.com
Thu Mar 1 15:11:45 AEDT 2018


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> We are populating 'opal-runtime-size' before calculating actual stack size.
> Hence we endup having wrong runtime size (ex: on P9 it shows ~540MB while
> actual size is around ~40MB). Note that only device tree property is shows
> wrong value, but reserved-memory reflects correct size.
>
> init_all_cpus() calculates and updates actual stack size. Hence move this
> function call before add_opal_node().
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  core/init.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

I'm pretty sure this is all okay and safe, and even though we probably
never ever have had anything look at that DT property, it may as well be
correct.

I don't think we have a problem doing init_all_cpus() before probing the
platform...

anyway, merged to master as of 1dacecd2b28b71b45982e3f063918dab78279cf5

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list