[Skiboot] [PATCH v2 1/5] pci: Move logging macros to pci.h

Stewart Smith stewart at linux.ibm.com
Tue Jul 31 13:23:52 AEST 2018

Reza Arbab <arbab at linux.ibm.com> writes:
> Move the PCI{TRACE,DBG,NOTICE,ERR} logging macros from pci.c to pci.h so
> they can be used in other files.
> Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
> Reviewed-by: Alistair Popple <alistair at popple.id.au>

I'm increasingly looking longingly at Oliver's patch that adds custom
printf specifiers that we could use for things like this... it'd
certainly make 'prlog' and 'prerror' more greppable rather than each
subsystem having their own #defines.


(this isn't a nack or anything, just a point for discussion/future

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list