[Skiboot] [PATCH] mambo: disable OPAL_SIGNAL_SYSTEM_RESET

Stewart Smith stewart at linux.ibm.com
Thu Jul 26 18:03:50 AEST 2018


Nicholas Piggin <npiggin at gmail.com> writes:
> mambo does not deliver system reset interrupts correctly (details in
> the added comment), so disable it for now.
>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> --
>
> This feature was useful for developing the NMI IPI system in Linux,
> but now it's somewhat working, and we've got OPAL_SIGNAL_SYSTEM_RESET
> implemented on real hardware (and equivalent hypercall for QEMU
> guests), it is less important now. It's annoing because it causes
> breaking to xmon to usually often crash the kernel in an SMP sim.

(looking back at patches I've neglected in patchwork as I have a notmuch
query for that now)

I'm interested in another alternative as we do have stupid unittests for
part of this code that is nice to have work.

I guess we could look at what idle states are enabled, and for the unit
tests, just enable none of them?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list